Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link): sheet link popup should attach to cell editor #4063

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners November 14, 2024 11:26
Copy link

github-actions bot commented Nov 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  18f312b
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@weird94 weird94 merged commit 7550f1c into dev Nov 14, 2024
9 checks passed
@weird94 weird94 deleted the fix/sheet-add-link branch November 14, 2024 11:33
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (820653c) to head (18f312b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4063      +/-   ##
==========================================
- Coverage   32.95%   32.94%   -0.01%     
==========================================
  Files        2497     2497              
  Lines      126919   126926       +7     
  Branches    28419    28421       +2     
==========================================
  Hits        41821    41821              
- Misses      85098    85105       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants