Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set pointer caputure when pointer out #4099

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: set pointer caputure when pointer out #4099

merged 3 commits into from
Nov 19, 2024

Conversation

lumixraku
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/3338

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 18, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  fd1d341
info  For more information, see full report

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0.47619% with 209 lines in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (8597d44) to head (fd1d341).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/scene.input-manager.ts 0.00% 134 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 40 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 17 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 7.69% 12 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4099      +/-   ##
==========================================
+ Coverage   33.04%   33.06%   +0.01%     
==========================================
  Files        2437     2437              
  Lines      126821   126749      -72     
  Branches    28393    28359      -34     
==========================================
+ Hits        41912    41913       +1     
+ Misses      84909    84836      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 19, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 19, 2024
@lumixraku lumixraku merged commit e194a1e into dev Nov 19, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/pointer-leave branch November 19, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants