Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc text selection begin from list marker #4132

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 23, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review November 23, 2024 06:22
@Jocs Jocs requested a review from jikkai as a code owner November 23, 2024 06:22
Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 45 seconds
commit  ea6bf5f
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (924ad5e) to head (ea6bf5f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...services/selection/doc-selection-render.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4132      +/-   ##
==========================================
- Coverage   33.74%   33.74%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127856   127858       +2     
  Branches    28629    28630       +1     
==========================================
  Hits        43141    43141              
- Misses      84715    84717       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Jocs Jocs merged commit 798e1fd into dev Nov 23, 2024
10 checks passed
@Jocs Jocs deleted the fix/selection-after-list branch November 23, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants