Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix client may miss the INITIALIZE event #4158

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 26, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 26, 2024

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 48 seconds
commit  6bac1f0
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

@wzhudev wzhudev merged commit f0234bb into dev Nov 26, 2024
8 of 9 checks passed
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.77%. Comparing base (a5041d2) to head (6bac1f0).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4158      +/-   ##
==========================================
+ Coverage   33.74%   33.77%   +0.03%     
==========================================
  Files        2457     2457              
  Lines      127861   127725     -136     
  Branches    28631    28605      -26     
==========================================
  Hits        43141    43141              
+ Misses      84720    84584     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev deleted the fix/rpc-client-missing branch November 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants