Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): fix type #4181

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(conditional-formatting): fix type #4181

merged 1 commit into from
Nov 28, 2024

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  b2cf07c
info  For more information, see full report

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (5627c25) to head (b2cf07c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ting-ui/src/controllers/cf.auto-fill.controller.ts 0.00% 1 Missing ⚠️
...ing-ui/src/controllers/cf.copy-paste.controller.ts 0.00% 1 Missing ⚠️
...atting-ui/src/controllers/cf.painter.controller.ts 0.00% 1 Missing ⚠️
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 1 Missing ⚠️
...tting-ui/src/controllers/cf.viewport.controller.ts 0.00% 1 Missing ⚠️
...l-formatting/src/models/calculate-unit-v2/utils.ts 0.00% 1 Missing ⚠️
...ckages/sheets-conditional-formatting/src/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4181   +/-   ##
=======================================
  Coverage   33.77%   33.77%           
=======================================
  Files        2487     2487           
  Lines      127668   127668           
  Branches    28601    28601           
=======================================
  Hits        43121    43121           
  Misses      84547    84547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 9db1edf into dev Nov 28, 2024
9 checks passed
@jikkai jikkai deleted the fix-cf-1128 branch November 28, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants