Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paste border should cover origin border #4321

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: paste border should cover origin border #4321

merged 2 commits into from
Jan 6, 2025

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 16, 2024

close https://github.com/dream-num/univer-pro/issues/2579

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 16, 2024

Playwright test results

passed  20 passed
flaky  1 flaky

Details

stats  21 tests across 10 suites
duration  4 minutes, 57 seconds
commit  7b74946
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff facade sheet hooks

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 17, 2024
@ybzky ybzky requested a review from VicKun4937 as a code owner December 17, 2024 07:27
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.37%. Comparing base (7e36387) to head (7b74946).
Report is 57 commits behind head on dev.

Files with missing lines Patch % Lines
...kages/sheets-ui/src/controllers/clipboard/utils.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4321   +/-   ##
=======================================
  Coverage   33.36%   33.37%           
=======================================
  Files        2515     2515           
  Lines      129819   129828    +9     
  Branches    29005    29008    +3     
=======================================
+ Hits        43317    43325    +8     
- Misses      86502    86503    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 7cdd2e6 into dev Jan 6, 2025
9 checks passed
@wzhudev wzhudev deleted the fix-paste-border branch January 6, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants