Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vp start sheet view column #4396

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix: vp start sheet view column #4396

merged 5 commits into from
Jan 2, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Dec 31, 2024

close https://github.com/dream-num/univer-pro/issues/3884

scrolling by wheel in no freeze.
scrolling by drag the scrollbar in no freeze.
scrolling by arrow key to change the current cell in no freeze.

scrolling by wheel after freeze.
scrolling by drag the scrollbar after freeze.
scrolling by arrow key to change the current cell after freeze.

TODO

  • More e2e case about viewport scrolling, include freeze & scroll by scrollbar & by wheel

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  2f802c0
info  For more information, see full report

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 10.20408% with 44 lines in your changes missing coverage. Please review.

Project coverage is 33.30%. Comparing base (612c981) to head (2f802c0).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/render-controllers/scroll.render-controller.ts 0.00% 27 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 12 Missing ⚠️
...ets-ui/src/commands/commands/set-scroll.command.ts 0.00% 3 Missing ⚠️
...s/sheets-ui/src/services/scroll-manager.service.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4396      +/-   ##
==========================================
- Coverage   33.30%   33.30%   -0.01%     
==========================================
  Files        2532     2532              
  Lines      130712   130735      +23     
  Branches    29167    29167              
==========================================
+ Hits        43540    43542       +2     
- Misses      87172    87193      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/vp-startSHeetViewColumn branch from a950953 to 6b5a0ff Compare December 31, 2024 08:05
@zhaolixin7
Copy link

冻结表格,向右拖拽滚动条,然后按向下方向键,表现:滚动条会自动跳到最左边
2024_12_31 16_43_58 video.webm

@univer-bot
Copy link

univer-bot bot commented Dec 31, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Freeze the table, drag the scroll bar to the right, and then press the down arrow key. Performance: the scroll bar will automatically jump to the left
2024_12_31 16_43_58 video.webm

@lumixraku lumixraku force-pushed the fix/vp-startSHeetViewColumn branch 6 times, most recently from f436a20 to 1d40bc5 Compare December 31, 2024 12:57
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jan 2, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jan 2, 2025
@lumixraku lumixraku force-pushed the fix/vp-startSHeetViewColumn branch from 1d40bc5 to a8c30eb Compare January 2, 2025 04:42
@lumixraku lumixraku force-pushed the fix/vp-startSHeetViewColumn branch from 2f89da6 to 2f802c0 Compare January 2, 2025 06:15
@lumixraku lumixraku merged commit 868e4b2 into dev Jan 2, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/vp-startSHeetViewColumn branch January 2, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants