Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support automatic line breaks for merged cells as well #4413

Closed
2 tasks done
zhangxianzhong opened this issue Jan 3, 2025 · 5 comments
Closed
2 tasks done
Assignees
Labels
feature request New feature or request wontfix This will not be worked on

Comments

@zhangxianzhong
Copy link

Initial checklist

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Problem

I want to use Univer to display multiple rows of data, but the number of cells required for each row is different, so I need to merge cells. After merging the cells, setting automatic line breaks does not work, and it cannot fully display the text content. I hope it can provide the same feature as Luckysheet, where merged cells automatically wrap text.

@zhangxianzhong zhangxianzhong added the feature request New feature or request label Jan 3, 2025
@jikkai
Copy link
Member

jikkai commented Jan 3, 2025

This behavior is somewhat similar to a border: merged cells must be configured with the same attributes for it to work properly. If you are certain that this feature has not been implemented, please provide a minimal reproduction.

@zhangxianzhong
Copy link
Author

sorry, my description is a bit wrong, after the merged cells wrap automatically, the height is fixed, and the height cannot be adapted

@zhangxianzhong
Copy link
Author

我看了0.4.2的源码,发现合并后的单元格在计算自动高度的时候直接跳过了,看是否可以在下个版本中调整优化一下,这个场景其实还挺常见的,之间的luckysheet似乎就可以
image

@univer-bot
Copy link

univer-bot bot commented Jan 3, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

I looked at the source code of 0.4.2 and found that the merged cells were skipped when calculating the automatic height. I will see if it can be adjusted and optimized in the next version. This scenario is actually quite common. The luckysheet seems to be That's it
image

@lumixraku
Copy link
Contributor

It was done this way on purpose, which is consistent with Microsoft Excel.

@jikkai jikkai added the wontfix This will not be worked on label Jan 4, 2025
@jikkai jikkai closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants