Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): ensure colorpicker trigger onChanged callback on mouseup event #4443

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jan 8, 2025

… event

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai changed the title fix(design): ensure colorpicker trigger onChanged callback on mouseup… fix(design): ensure colorpicker trigger onChanged callback on mouseup event Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 8, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 13 seconds
commit  be02dad
info  For more information, see full report

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 32.61%. Comparing base (c4d8a1b) to head (be02dad).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...sign/src/components/color-picker/ColorSpectrum.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4443      +/-   ##
==========================================
+ Coverage   32.60%   32.61%   +0.01%     
==========================================
  Files        2575     2575              
  Lines      133679   133681       +2     
  Branches    29737    29736       -1     
==========================================
+ Hits        43581    43602      +21     
+ Misses      90098    90079      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 32f1d30 into dev Jan 8, 2025
10 checks passed
@jikkai jikkai deleted the fix/colorpicker branch January 8, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant