Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): fix facade throw error #4466

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(sheet): fix facade throw error #4466

merged 1 commit into from
Jan 13, 2025

Conversation

VicKun4937
Copy link
Contributor

  • fix facde error

@VicKun4937 VicKun4937 requested a review from weird94 as a code owner January 13, 2025 10:08
Copy link

github-actions bot commented Jan 13, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 14 seconds
commit  3810f1e
info  For more information, see full report

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.58%. Comparing base (88a0c86) to head (3810f1e).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-range.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4466      +/-   ##
==========================================
- Coverage   32.60%   32.58%   -0.03%     
==========================================
  Files        2575     2575              
  Lines      133708   133807      +99     
  Branches    29741    29751      +10     
==========================================
  Hits        43602    43602              
- Misses      90106    90205      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit e53eb2c into dev Jan 13, 2025
9 checks passed
@jikkai jikkai deleted the fix-facade-error branch January 13, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants