Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): cell precision error #4476

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jan 14, 2025

Problem

Importing Excel with formulas, the formula cell contains the v value of a string, the cell type is a number, and the cell number format is General, then the number precision is not processed

image

snapshot-formula-0114.json

What's updated?

  • cell.t is a number, v is a numeric string, use isRealNum to determine
  • cell.s.pattern is General, the number precision should also be processed, refer to Excel

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  9c19263
info  For more information, see full report

@Dushusir Dushusir requested a review from wpxp123456 January 14, 2025 08:14
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.80%. Comparing base (7957d95) to head (9c19263).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...llers/array-formula-cell-interceptor.controller.ts 0.00% 1 Missing ⚠️
...s/sheets/src/controllers/number-cell.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4476      +/-   ##
==========================================
- Coverage   32.82%   32.80%   -0.02%     
==========================================
  Files        2595     2595              
  Lines      133973   133973              
  Branches    29805    29805              
==========================================
- Hits        43975    43954      -21     
- Misses      89998    90019      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/sheet-cell-precision-0114 branch from 1cab227 to 9c19263 Compare January 16, 2025 06:34
@Dushusir Dushusir merged commit 99b2600 into dev Jan 16, 2025
9 checks passed
@Dushusir Dushusir deleted the dushusir/sheet-cell-precision-0114 branch January 16, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants