Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): data validation validator issues #4477

Merged
merged 10 commits into from
Jan 14, 2025
Merged

fix(sheets): data validation validator issues #4477

merged 10 commits into from
Jan 14, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 14, 2025

close https://github.com/dream-num/univer-pro/issues/3773
close https://github.com/dream-num/univer-pro/issues/3697
close https://github.com/dream-num/univer-pro/issues/3832
close https://github.com/dream-num/univer-pro/issues/2829
close https://github.com/dream-num/univer-pro/issues/3874
close https://github.com/dream-num/univer-pro/issues/3875

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  22 passed
flaky  1 flaky

Details

stats  23 tests across 10 suites
duration  6 minutes, 37 seconds
commit  4b004a1
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 3.63636% with 53 lines in your changes missing coverage. Please review.

Project coverage is 32.80%. Comparing base (52b2300) to head (4b004a1).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ages/core/src/docs/data-model/rich-text-builder.ts 0.00% 30 Missing ⚠️
...data-validation/src/validators/custom-validator.ts 0.00% 6 Missing ⚠️
...-mention-ui/src/views/mention-edit-popup/index.tsx 0.00% 3 Missing ⚠️
...kages/docs-ui/src/controllers/menu/context-menu.ts 0.00% 3 Missing ⚠️
...rc/views/range-selector/hooks/useRefactorEffect.ts 0.00% 3 Missing ⚠️
packages/docs-ui/src/basics/paragraph.ts 50.00% 2 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 2 Missing ⚠️
...kages/docs-ui/src/views/rich-text-editor/index.tsx 0.00% 1 Missing ⚠️
...kages/sheets-data-validation/src/facade/f-range.ts 0.00% 1 Missing ⚠️
...ta-validation/src/services/dv-validator-service.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4477      +/-   ##
==========================================
- Coverage   32.82%   32.80%   -0.02%     
==========================================
  Files        2581     2582       +1     
  Lines      132849   132924      +75     
  Branches    29525    29556      +31     
==========================================
+ Hits        43610    43611       +1     
- Misses      89239    89313      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 removed the qa:untested This PR is ready to be tested label Jan 14, 2025
@weird94 weird94 merged commit 29b6f9a into dev Jan 14, 2025
9 checks passed
@weird94 weird94 deleted the fix/daily-0114 branch January 14, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants