Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderUnit is not sheet in prev way #4492

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: renderUnit is not sheet in prev way #4492

merged 1 commit into from
Jan 15, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 15, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku
Copy link
Contributor Author

企业微信截图_551662a5-fea7-4d1f-a471-b8b8f6bf5a32

@univer-bot
Copy link

univer-bot bot commented Jan 15, 2025

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Enterprise WeChat screenshot_551662a5-fea7-4d1f-a471-b8b8f6bf5a32

@lumixraku
Copy link
Contributor Author

check
univerAPI.addEvent('Scroll', (p)=> {console.log('s', p)})

@lumixraku lumixraku force-pushed the fix/scroll-facade-api branch from 504e3e8 to a51966f Compare January 15, 2025 12:16
Copy link

github-actions bot commented Jan 15, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 14 seconds
commit  a51966f
info  For more information, see full report

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.97%. Comparing base (fdd876b) to head (a51966f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-univer.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4492      +/-   ##
==========================================
- Coverage   32.97%   32.97%   -0.01%     
==========================================
  Files        2592     2592              
  Lines      133342   133344       +2     
  Branches    29645    29646       +1     
==========================================
  Hits        43975    43975              
- Misses      89367    89369       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky merged commit b40bc0d into dev Jan 15, 2025
9 checks passed
@ybzky ybzky deleted the fix/scroll-facade-api branch January 15, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants