Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind multiple times for UIEvent after dispose and create again #4500

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 16, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku changed the title fix: bind multiple times for UIEvent fix: bind multiple times for UIEvent after dispose and create again Jan 16, 2025
@lumixraku
Copy link
Contributor Author

lumixraku commented Jan 16, 2025

test
univerAPI.addEvent('SelectionMoveEnd', (p)=> {console.log('s', p)})
univerAPI.disposeUnit('workbook-01')
univerAPI.createUniverSheet({})

event should be bind twice

Copy link

github-actions bot commented Jan 16, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 8 seconds
commit  0176870
info  For more information, see full report

@lumixraku lumixraku force-pushed the fix/scroll-facade-api branch 6 times, most recently from bb0f229 to 12f40da Compare January 16, 2025 05:09
@lumixraku lumixraku force-pushed the fix/scroll-facade-api branch 2 times, most recently from 82b3dec to 70f67b7 Compare January 16, 2025 06:29
@lumixraku lumixraku force-pushed the fix/scroll-facade-api branch from 70f67b7 to 0176870 Compare January 16, 2025 06:30
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 32.82%. Comparing base (7957d95) to head (0176870).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-univer.ts 0.00% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4500      +/-   ##
==========================================
- Coverage   32.82%   32.82%   -0.01%     
==========================================
  Files        2595     2595              
  Lines      133973   133976       +3     
  Branches    29805    29805              
==========================================
  Hits        43975    43975              
- Misses      89998    90001       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku merged commit 5e6cd64 into dev Jan 16, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/scroll-facade-api branch January 16, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants