Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: float dom event #4514

Merged
merged 5 commits into from
Jan 17, 2025
Merged

fix: float dom event #4514

merged 5 commits into from
Jan 17, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 17, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 17, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 10 seconds
commit  bcf6163
info  For more information, see full report

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (5349885) to head (bcf6163).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 52 Missing ⚠️
...mponents/sheets/extensions/column-header-layout.ts 0.00% 3 Missing ⚠️
.../components/sheets/extensions/row-header-layout.ts 0.00% 1 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4514      +/-   ##
==========================================
- Coverage   32.68%   32.68%   -0.01%     
==========================================
  Files        2597     2597              
  Lines      134532   134551      +19     
  Branches    29928    29936       +8     
==========================================
  Hits        43975    43975              
- Misses      90557    90576      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/auto-complete2 branch from 76bec15 to bcf6163 Compare January 17, 2025 10:23
@lumixraku lumixraku merged commit 4d13d75 into dev Jan 17, 2025
9 checks passed
@lumixraku lumixraku deleted the feat/auto-complete2 branch January 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants