Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airDatepickerInput(): Bugs in language, inline and timezone #553

Closed
Riraro opened this issue Dec 6, 2022 · 1 comment
Closed

airDatepickerInput(): Bugs in language, inline and timezone #553

Riraro opened this issue Dec 6, 2022 · 1 comment

Comments

@Riraro
Copy link

Riraro commented Dec 6, 2022

Hey there, first thanks for the awesome Widgets your project provides, it's a pleasure to use them!

I'm trying to integrate the airDatepickerInput() into my app (shinyWidgets v.0.7.5), but ran into 3 bugs (minimal example at the end):

  1. The displayed time is always am instead of pm when passing a time after midday.
  2. When using language = "de" the widget displays ii instead of the minutes.
  3. When using inline = TRUE the time specified in value is ignored and the widget uses the current time.

Thanks for your support!

2022-12-06 12_15_24-Window

library(shiny)
library(shinyWidgets)

ui <- fluidPage(
  br(),
  airDatepickerInput(
    inputId = "timezone",
    label = "timezone wrong (should be pm)",
    value = as.POSIXct("2022-02-15 22:00:00"),
    timepicker = TRUE
  ),
  verbatimTextOutput(outputId = "timezone"),
  br(),
  airDatepickerInput(
    inputId = "language",
    label = "'language = \"de\"' broken (no minutes displayed)",
    value = as.POSIXct("2022-02-15 22:00:00"),
    timepicker = TRUE,
    language = "de"
  ),
  verbatimTextOutput(outputId = "language"),
  br(),
  airDatepickerInput(
    inputId = "inline",
    label = "'inline = TRUE' broken (wrong time)",
    value = as.POSIXct("2022-02-15 22:00:00"),
    timepicker = TRUE,
    inline = TRUE
  ),
  verbatimTextOutput(outputId = "inline")
)

server <- function(input, output, session) {
  output$timezone <- renderPrint(input$timezone)
  output$language <- renderPrint(input$language)
  output$inline <- renderPrint(input$inline)
}

shinyApp(ui = ui, server = server)
@pvictor pvictor closed this as completed in 45475f8 Dec 9, 2022
@pvictor
Copy link
Member

pvictor commented Dec 9, 2022

Hello,
Thank you for reporting this, those issues have been fixed in latest air-datepicker release, if you install shinyWidgets from GitHub it'll be ok.

Victor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants