Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cursor should exit early if now more rows are returned. #235

Open
1 task done
c-thiel opened this issue Jul 2, 2024 · 0 comments
Open
1 task done

[Bug]: Cursor should exit early if now more rows are returned. #235

c-thiel opened this issue Jul 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@c-thiel
Copy link

c-thiel commented Jul 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

On many Operations, Dremio does not return the actual row count of the result sets as "rowCount", but instead a number related to the operation.
A good example is an insert: If you insert 1_000_000 rows into a table, Dremio will show a "rowCount" of 1_000_000 (Dremio 24.2.6). However, the result set of course only has one row - the number of inserted rows.

Due to the implementation here:

the cursor iterates over hundreds of thousands of empty resultsets.

Expected Behavior

As we cannot count on Dremio returning the number of results in "rowCount" we should probably just break when we hit the first empty batch of results.

Steps To Reproduce

No response

Environment

- OS: K8s
- dbt-dremio: 1.7.0
- Dremio Software: 24.2.6
- Dremio Cloud: -

Relevant log output

No response

@c-thiel c-thiel added the bug Something isn't working label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant