Latest Brackets changes hide file labels

[le717]

adobe/brackets#10011, which will be in the upcoming 1.1 release, changes the positioning the of file tree labels, and subsequently this extension breaks by hiding all labels.

[geekosaurusR3x]

+1

[AdriVanHoudt]

I get this error

 Registering for deprecated event 'workingSetAdd'. Instead, use MainViewManager.workingSetAdd. Error
    at Object.on (/utils/EventDispatcher.js:100:43)
    at Object.<anonymous> (file:///C:/Users/adri/AppData/Roaming/Brackets/extensions/user/drewkoch.icons/main.js:190:21)
    at Object.context.execCb (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:1658:33)
    at Object.Module.check (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:869:55)
    at Object.Module.enable (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:1151:22)
    at Object.Module.init (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:782:26)
    at callGetModule (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:1178:63)
    at Object.context.completeLoad (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:1552:21)
    at HTMLScriptElement.context.onScriptLoad (file:///C:/Program%20Files%20(x86)/Brackets/www/thirdparty/requirejs/require.js:1679:29)

[AdriVanHoudt]

I might try updating this extension with my 0 knowledge of Brackets extensions but I already hacked something together 💪

[timbuktuuu]

For a quick and dirty hotfix use Brackets-Icons and change the Fonts/Icons Code.

[AdriVanHoudt]

Since every icon is defined in code I would not call that quick :D but maybe in the future Brackets-Icons can export the icon definitions to a config file and make it swappable

[fabre-thibaud]

Same here after update to latest Brackets release (Release 1.1 experimental build 1.1.0-15558 (release ea908cae5) -- installed via package available on website)

[AdriVanHoudt]

I've updated the extension myself (https://github.com/AdriVanHoudt/Brackets-File-Icons) you can manually pull it into your Brackets extension folder (see Help > Show Extension Folder in Brackets menu). I'll make a pull request but since @drewbkoch is pretty inactive I don't expect much from it

[fabre-thibaud]

Nice, I'll give it a try. I wouldn't be so pessimistic for the P/R, I see that he recently merged one last month, so he'll probably pop back if you do one too.

[AdriVanHoudt]

There is also one from Aug 14 ^^ also he probably was tired of my spam on #10 😆

[le717]

@AdriVanHoudt You don't have to hack anything. Only the #project-files-container a CSS rule needs to be dramatically decreased, adjusted to leave some space between the icon and text (unlike in your image above), and the minimum Brackets needs to be increased to >=1.1.0. Alternatively, you could parse the Brackets version and set the appropriate padding dynamically via JavaScript. 😄

[AdriVanHoudt]

@le717 check my commits on https://github.com/AdriVanHoudt/Brackets-File-Icons ;)

[AdriVanHoudt]

should be fixed #14

[le717]

@AdriVanHoudt Is this confirmed fixed?

[AdriVanHoudt]

@le717 what? The main issue, yes.

[AdriVanHoudt]

There is an update in Brackets waiting for you ;)

[AdriVanHoudt]

@le717 if you can close issues maybe go over older ones and see if they are still valid

[le717]

I can only close issues I opened, namely this one. ;)

[AdriVanHoudt]

TIL 😄