-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression Tests producing different data #626
Comments
Are those diffs in the Java files or the .NET ones? For Java, perhaps we need something like For .NET it'd be |
Ug I hadn't had my coffee --that's exactly what your PR that I approved yesterday does :) |
Yes, that solved the issues regarding number formatting. I tried setting default encoding to utf 8 but that doesn't made a difference (I guess that is default on java anyways) Can you tell me on which os and locale you're running these tests? If nothing helps I would configure an environment m |
I'm on Windows 11, running on en-AU. I've made some progress on date formatting, by converting everything to UTC in the output files and will push that up later today hopefully. Were you seeing diffs in the .NET files or the Java ones? |
BTW you can workaround the issue here by running the suite without your changes and staging the diff, then running with your changes and comparing the workspace with the index. |
Alright, I just wanted to make sure it has nothing to Do with linux/windows encoding. Will then probably go the git staging route to compare the cr3 PR changes. |
That probably makes the most sense for now. I can re-run your branch against the regression set too, as an extra check. |
When running the regression test (Windows 11 JVM, German OS + German Timezone - please also see PR #625 ) I'm getting a diff in multiple files, especially comments or special data. It looks like an issue with file encoding, but I can't figure out what is causing it.
Some examples:
Any help/assistance would be appreciated!
The text was updated successfully, but these errors were encountered: