Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBaseQuery -> toBase was reverted in Laravel 10 #129

Closed
joelvh opened this issue Aug 22, 2023 · 0 comments · Fixed by #130
Closed

getBaseQuery -> toBase was reverted in Laravel 10 #129

joelvh opened this issue Aug 22, 2023 · 0 comments · Fixed by #130

Comments

@joelvh
Copy link
Contributor

joelvh commented Aug 22, 2023

The deprecated getBaseQuery was initially removed, but then it was added back because it caused a regression.

I think this should be removed from the Laravel 10 set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove reverted Laravel 10 rule (getBaseQuery -> toBase) joelvh/rector-laravel
1 participant
@joelvh