Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.2 release has API-breaking changes #65

Open
qwandor opened this issue Jun 8, 2022 · 1 comment
Open

0.5.2 release has API-breaking changes #65

qwandor opened this issue Jun 8, 2022 · 1 comment

Comments

@qwandor
Copy link
Contributor

qwandor commented Jun 8, 2022

The 0.5.2 release of this crate adds lifetime parameters to several structs (Value and Point) in #62. This is an API breaking change, as code which uses these types may no longer compile without code changes. E.g. I had a function like

fn point_for_property_value(
    device: &Device,
    node: &Node,
) -> Point {
  // ...
}

which worked fine with influx-db-client 0.5.1, but with 0.5.2 it fails to build due to the missing lifetime parameter on Point which can't be inferred.

I suggest you yank 0.5.2 and re-release it as 0.6.0.

@driftluo
Copy link
Owner

driftluo commented Jun 9, 2022

already yank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants