Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Commit 77edbc6

Browse files
marcorosidanbucholtz
authored andcommitted
fix(serve): Fix for browser not opening on linux, fixes #425 (#909)
1 parent a8616eb commit 77edbc6

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/serve.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,11 @@ function onReady(config: ServeConfig, context: BuildContext) {
7676
.concat(browserOption(context) ? [browserOption(context)] : [])
7777
.concat(platformOption(context) ? ['?ionicplatform=', platformOption(context)] : []);
7878

79-
open(openOptions.join(''), browserToLaunch(context));
79+
open(openOptions.join(''), browserToLaunch(context),(error:any) => {
80+
if (error) {
81+
Logger.warn(`Sorry.. unable to open the browser for you: ${error}`);
82+
}
83+
});
8084
}
8185
Logger.info(`dev server running: ${config.hostBaseUrl}/`, 'green', true);
8286
Logger.newLine();

src/util/open.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ export default function (target: string, appName: string | Function, callback?:
4343
if (typeof appName === 'string') {
4444
opener = escape(appName);
4545
} else {
46-
// use Portlands xdg-open everywhere else
47-
opener = path.join(__dirname, '../vendor/xdg-open');
46+
//use system installed Portlands xdg-open everywhere else
47+
opener = 'xdg-open';
4848
}
4949
break;
5050
}

0 commit comments

Comments
 (0)