fix(tap): Do not detect taps for input[type=file], closes #652

ionic-team · Mar 10, 2014 · 6f2d6e7 · 6f2d6e7
1 parent c91622b
commit 6f2d6e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/ext/angular/test/clickTests.html b/js/ext/angular/test/clickTests.html
@@ -41,6 +41,7 @@
  <form id="form">
   <button class="button" ng-click="buttonClick()">button</button>
   <div class="div button" ng-click="divClick()">div</div>
+  <input type="file">
   {{ buttonValue }} -
   {{ radioModel.data }}
 

diff --git a/js/utils/poly.js b/js/utils/poly.js
@@ -78,7 +78,7 @@
 
     var ele = target.control || target;
 
-    if(ele.disabled) return;
+    if(ele.disabled || ele.type === 'file') return;
 
     console.debug('tapElement', ele.tagName, ele.className);
 
@@ -126,7 +126,7 @@
 
     for(var x=0; x<5; x++) {
       // climb up the DOM looking to see if the tapped element is, or has a parent, of one of these
-      // only climb up a max of 5 parents, anything more is probably isn't beneficial
+      // only climb up a max of 5 parents, anything more probably isn't beneficial
       if(!ele) break;
 
       if( ele.tagName === "INPUT" ||