Skip to content

Commit

Permalink
fix(ion-fixed): ion-fixed directive is not longer needed
Browse files Browse the repository at this point in the history
  • Loading branch information
manucorporat committed Sep 26, 2016
1 parent b70614b commit 75d5526
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
13 changes: 0 additions & 13 deletions src/components/fixed/fixed.ts

This file was deleted.

3 changes: 0 additions & 3 deletions src/directives.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { Chip } from './components/chip/chip';
import { Content } from './components/content/content';
import { DateTime } from './components/datetime/datetime';
import { FabContainer, FabButton, FabList } from './components/fab/fab';
import { Fixed } from './components/fixed/fixed';
import { Grid, Row, Col } from './components/grid/grid';
import { Icon } from './components/icon/icon';
import { Img } from './components/img/img';
Expand Down Expand Up @@ -81,7 +80,6 @@ export { Chip } from './components/chip/chip';
export { Content } from './components/content/content';
export { DateTime } from './components/datetime/datetime';
export { FabContainer, FabButton, FabList } from './components/fab/fab';
export { Fixed } from './components/fixed/fixed';
export { Grid, Row, Col } from './components/grid/grid';
export { Icon } from './components/icon/icon';
export { Img } from './components/img/img';
Expand Down Expand Up @@ -176,7 +174,6 @@ export const IONIC_DIRECTIVES: any[] = [
FabContainer,
FabButton,
FabList,
Fixed,
Footer,
Grid,
Header,
Expand Down

2 comments on commit 75d5526

@ramonornela
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manucorporat No is best add deprecated in RC1 delete 😉

@manucorporat
Copy link
Contributor Author

@manucorporat manucorporat commented on 75d5526 Sep 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramonornela I agree, but ion-fixed received important improvements that make it difficult to provide a back-compatible solution: a98e209

<ion-fixed> --> <div ion-fixed>

(div or any element)

Please sign in to comment.