fix(util): Fix preventDefault logic in ionic.Gesture.gestures.Drag

Fixes #4008 fix(ionSideMenu): prevent native scrolling when menu is open
ionic-team · Jul 14, 2015 · e10b5d2 · e10b5d2
1 parent b426556
commit e10b5d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/utils/gestures.js b/js/utils/gestures.js
@@ -1171,8 +1171,8 @@
 
       } else if (!this.preventedFirstMove && ev.srcEvent.type == 'touchmove') {
         // Prevent gestures that are not intended for this event handler from firing subsequent times
-        if (inst.options.prevent_default_directions.length === 0
-            || inst.options.prevent_default_directions.indexOf(ev.direction) != -1) {
+        if (inst.options.prevent_default_directions.length > 0
+            && inst.options.prevent_default_directions.indexOf(ev.direction) != -1) {
           ev.srcEvent.preventDefault();
         }
         this.preventedFirstMove = true;

diff --git a/scss/_menu.scss b/scss/_menu.scss
@@ -35,6 +35,7 @@
 .menu-open .menu-content .pane,
 .menu-open .menu-content .scroll-content {
   pointer-events: none;
+  overflow: hidden;
 }
 
 .grade-b .menu-content,