bug: Action sheet has no method cancel #1013
Comments
bluehallu
pushed a commit
to bluehallu/ionic
that referenced
this issue
Jun 5, 2014
The fix @ajoslin provided doesn't work. All what's being extended in his fix is later overloaded 20 lines below (scope.destructiveButtonClicked, scope.buttonClicked and scope.cancel). Furthermore, the error doesn't come from calling scope.cancel() but from calling opts.cancel(). I've eliminated the redundant code and also fixed the original bug.
bluehallu
pushed a commit
to bluehallu/ionic
that referenced
this issue
Jun 5, 2014
The fix that was supposed to close this doesn't: ionic-team@ba39fb0 The real problem was that cancel was being called on opts and not on scope. The code by @ajoslin is redundant as all the three functions he gives a default angular.noop are overloaded 20 lines below so I reverted it.
ajoslin
pushed a commit
that referenced
this issue
Jun 6, 2014
|
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Type: bug
Platform: all
When I click the cancel button for an Action Sheet using the example in the docs I get this error. "TypeError: Object # has no method 'cancel'".
The text was updated successfully, but these errors were encountered: