Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'auto-play' as API's attribute to slideBox.js #1552

Closed
wants to merge 1 commit into from

Conversation

joilsonmarques
Copy link

Now you can use 'auto-play' and 'does-continue' as parameters separated.

<ion-slide-box does-continue="true" auto-play="false">
    <ion-slide>Slide 1</ion-slide>
    <ion-slide>Slide 2</ion-slide>
    <ion-slide>Slide 3</ion-slide>
</ion-slide-box>

@perrygovier
Copy link
Contributor

Thanks @joilsonmarques, we'll take a look and run it through our tests to make sure it doesn't break anything.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 12, 2014

It seems like this would break previous functionality? For backwards compatibility, auto-play should default to true if continuous is true.

But I'm not sure if I like this attribute either. what's the use case?

@keithdmoore
Copy link
Contributor

+1 I could use this feature. In my case, I want to goto the beginning if the user swipes left on the last slide. However, I do NOT want the slide box to auto play.

@ajoslin ajoslin self-assigned this Jul 7, 2014
@ajoslin ajoslin closed this in 8f80860 Jul 7, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Jul 7, 2014

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants