Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-swipe-down #1810

Closed
andrewmcgivery opened this issue Jul 21, 2014 · 3 comments
Closed

on-swipe-down #1810

andrewmcgivery opened this issue Jul 21, 2014 · 3 comments
Assignees

Comments

@andrewmcgivery
Copy link
Contributor

Looks like there is a bug with the on-swipe-down directive in Beta 9.

http://stackoverflow.com/questions/24853186/swipe-down-event-not-firing-ionic-framework

Look like instead of looking for the event onSwipeDown, it is currently onSwipeBottom, as found in the bundle.js fileon like 40918.

Line 40918 is currently:

    'onHold onTap onTouch onRelease onDrag onDragUp onDragRight onDragDown onDragLeft onSwipe onSwipeUp onSwipeRight onSwipeBottom onSwipeLeft'.split(' '),

Should be:

    'onHold onTap onTouch onRelease onDrag onDragUp onDragRight onDragDown onDragLeft onSwipe onSwipeUp onSwipeRight onSwipeDown onSwipeLeft'.split(' '),

I would do a pull request, but I want to make sure this wouldn't break anything else first. :)

@mhartington
Copy link
Contributor

Hey @andrewmcgivery, the best way to handle this would be to edit the source file, and make a test or codepen that shows the problem and the solution.

If you're not up for making a PR, can you illustrate the issue and a codepen and we can fix it?

@mhartington mhartington self-assigned this Jul 22, 2014
@andrewmcgivery
Copy link
Contributor Author

There is a codepen in that stack overflow question, but here is a forked version that writes to the console to make it more clear.

http://codepen.io/andrewmcgivery/pen/sHcaz

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants