Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Popups always show scroll bars #3204

Closed
danjohnso opened this issue Feb 28, 2015 · 11 comments
Closed

bug: Popups always show scroll bars #3204

danjohnso opened this issue Feb 28, 2015 · 11 comments
Assignees
Milestone

Comments

@danjohnso
Copy link

Type: bug

Platform: android 4.4 webview

This is an issue in the nightly build, I have not checked ios but the issue could be there as well. Scroll bars always show in the popups all the time, regardless of whether or not there is content to scroll. Issue appears in the doc example as well: http://ionicframework.com/docs/nightly/api/service/$ionicPopup/

@jclalala
Copy link

jclalala commented Mar 9, 2015

+1 I see it in as well from Chrome Browser and Android device.

@jbollacke
Copy link

Same here. No scrollbars on iOS though.

@tomkuipers
Copy link

+1

1 similar comment
@gaguirre
Copy link

+1

gaguirre pushed a commit to ingameio/ionic that referenced this issue Mar 17, 2015
@spyjo
Copy link

spyjo commented Mar 18, 2015

I also see this problem, on alert or confirm popup on Android 4.4

@BarryReid
Copy link

+1

@perrygovier perrygovier added this to the 1.0.0-rc2 milestone Mar 20, 2015
@perrygovier perrygovier self-assigned this Mar 20, 2015
@perrygovier perrygovier removed the ready label Mar 20, 2015
@sikron
Copy link

sikron commented Mar 22, 2015

Hi,
fix is not working for me (Android 4.4). Should i open a new issue?

@tomkuipers
Copy link

@sikron, I tested on my Android 4.4.2 (HTC Desire 601) and the fix is working for me...

@sikron
Copy link

sikron commented Mar 23, 2015

Hi,
thx for answering! I have the Android 4.4.4 (Cyanogenmod 11) Chrome running on a Samsung Galaxy S2. My Ionic version is 1.0.0-rc1 and i just exchanged "scroll" with "auto". There should have been nothing else to change, right?
I will try with rc2 as soon as possible.
EDIT: i misread the milestone. I just tried again after a "ionic lib update" (to be totally clean) and the issue persists.
EDIT 2: i updated from 1.0.0-beta.13. The issue did not exists in this version.

@tomkuipers
Copy link

To quickly check if this solution worked, in ionic.app.css (and ionic.app.min.css when using minified version) I changed class .popup-body and set 'overflow' to 'auto'.
Or you could change it in .popup.scss and run 'gulp sass' afterwards to generate the css files.
I am also running 1.0.0-rc1, which is the latest (according to 'ionic lib' at the moment), and made the change locally. It should be fixed automatically once 1.0.0-rc2 is released and you run 'ionic lib update' again.

@Fayozjon
Copy link

Tom

http://bonsezon.ru/analiz

24.03.2015, 17:29, "Tom Kuipers" notifications@github.com:To quickly check if this solution worked, in ionic.app.css (and ionic.app.min.css when using minified version) I changed class .popup-body and set 'overflow' to 'auto'.
Or you could change it in .popup.scss and run 'gulp sass' afterwards to generate the css files.
I am also running 1.0.0-rc1, which is the latest (according to 'ionic lib' at the moment), and made the change locally. It should be fixed automatically once 1.0.0-rc2 is released and you run 'ionic lib update' again.

—Reply to this email directly or .

@Fayozjon
Copy link

sikron

http://teklareka.rs/mmcis-schet

23.03.2015, 19:09, "sikron" notifications@github.com:Hi,
thx for answering! I have the Android 4.4.4 (Cyanogenmod 11) Chrome running on a Samsung Galaxy S2. My Ionic version is 1.0.0-rc1 and i just exchanged "scroll" with "auto". There should have been nothing else to change, right?
I will try with rc2 as soon as possible.

—Reply to this email directly or .

@sikron
Copy link

sikron commented Mar 24, 2015

My bad, i did not know, i had to do the "gulp sass" step. I actually thought, that ionic cli would do this for me :-) Now it works as expected.
@tomkuipers Thank you very much!

@Fayozjon
Copy link

Barry

http://zag-zag.ru/capital

19.03.2015, 15:16, "Barry Reid" notifications@github.com:+1

—Reply to this email directly or .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants