Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inset Modals #5423

Closed
adamdbradley opened this issue Feb 11, 2016 · 6 comments
Closed

Inset Modals #5423

adamdbradley opened this issue Feb 11, 2016 · 6 comments
Milestone

Comments

@adamdbradley
Copy link
Contributor

  • Like inset dialogs vs. full screen dialogs in Material Design
  • An option for presenting Modals
  • Inset modals should be the default on screens larger than X
@jabas06
Copy link

jabas06 commented Apr 19, 2016

Hi,

Will this feature be like android bottom sheets?

https://www.google.com/design/spec/components/bottom-sheets.html#

@jgw96
Copy link
Contributor

jgw96 commented Apr 19, 2016

Hey @jabas06. The bottom sheets that you're talking about are more similar to our action sheet: http://ionicframework.com/docs/v2/2.0.0-alpha.40/api/components/action-sheet/ActionSheet/. Good question!

@jabas06
Copy link

jabas06 commented Apr 19, 2016

Yes, I realize.

But what about "Persistent bottom sheets"? Similar to modals but without a backdrop and not fullscreen, so the user can interact with the rest of the content.

https://www.google.com/design/spec/components/bottom-sheets.html#bottom-sheets-persistent-bottom-sheets

It's not clear to me what is this Ionic's feature (Inset Modals) about.

@jgw96
Copy link
Contributor

jgw96 commented Apr 20, 2016

@jabas06 ahh, so yep this feature is not persistent bottom sheets, but that would be a cool feature. If your interested in seeing that added to the framework potentially feel free to open an issue requesting it as a feature! Inset modals would be like how native modals work on on bigger Android tablets. Currently in native Android on phones a modal takes up full screen but on bigger Android tablets (pixel c, Nexus 9) modals do not take up full screen and start to look almost like alerts but with more content. Hope that explains all this well!

@Mobius77x
Copy link

Mobius77x commented May 7, 2016

May I request that for the inset modals:

1 - the amount of inset can be specified as both % of the view width and % of the view height to ensure responsiveness of modal dimensions on any device
2 - can be set (via an option?) to always be in the center of the view (for any device), similarly to Loading and Alert.
3 - ability to set the transition so that you can have the modal 'pop up' instead of slide-in from bottom etc.

Thanks!

adamdbradley pushed a commit that referenced this issue May 18, 2016
* feat(inset-modal): add dynamic component loading functionality for inset modal

* style(modal): moved border-radius to a variable, added an additional data binding activity in moved border-radius to a variable, added an additional data binding activity in an e2e test

* refactor(modal): refactor sass and remove some unnecessary stuff

* refactor(modal): migrate to Angular RC import syntax

Closes #5423
@mnasyrov
Copy link

Is it possible to subscribe to an event when a user click on modal's backdrop in the inset mode? I'd like to have ability to dismiss a modal in this case.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants