Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu improvements #5535

Closed
5 tasks done
brandyscarney opened this issue Feb 19, 2016 · 0 comments
Closed
5 tasks done

Menu improvements #5535

brandyscarney opened this issue Feb 19, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.2

Comments

@brandyscarney
Copy link
Member

Need to be able to enable/disable menus from the @App class and then use the menuToggle from individual pages to toggle this menu.

  • Add logic to disable all other menus when enabling one (look by side left or right)
  • Be able to use menuToggle="left" and grab the active menu without having to set an ID
  • Still be able to pass an id to menuToggle and use that ID
  • If menu toggle isn't set at all just get the first active one
  • should we disable swipe of a menu & menuToggle when it is disabled?

Add unit tests for all of these
@brandyscarney brandyscarney self-assigned this Feb 19, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.2 milestone Feb 19, 2016
@brandyscarney brandyscarney changed the title Menu refactor Menu improvements Feb 19, 2016
brandyscarney added a commit that referenced this issue Feb 19, 2016
@brandyscarney
feat(menu): grab the menu by side only if it is enabled
a2b7a21 
this removes the need to pass an id when you enable one menu

references #5535
brandyscarney added a commit that referenced this issue Feb 19, 2016
@brandyscarney
test(menu): update test to use 3 menus and menu toggle by side
f0b5838 
references #5535
brandyscarney added a commit that referenced this issue Feb 20, 2016
@brandyscarney
fix(menu): fix enabled check
8564d79 
references #5535
adamdbradley added a commit that referenced this issue Feb 20, 2016
@adamdbradley
refactor(menu): improve menu get lookup
004e635 
If a `menuId` is not provided then it'll return the first menu found.
If a `menuId` is `left` or `right`, then it'll return the enabled menu
on that side. Otherwise, if a `menuId` is provided, then it'll try to
find the menu using the menu's `id` property. If a menu is not found
then it'll return `null`. If a menu id was provided, but was not found,
it will not fallback to finding any menu. Closes #5535
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.2
Development

No branches or pull requests
3 participants
@adamdbradley @brandyscarney @Ionitron