Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of tabbarIcons #6126

Closed
brandyscarney opened this issue Apr 11, 2016 · 0 comments
Closed

Get rid of tabbarIcons #6126

brandyscarney opened this issue Apr 11, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.5

Comments

@brandyscarney
Copy link
Member

Right now tabbarIcons is still showing but deprecated, also tabbarIcons is still being used in tabs.wp.scss

Should be using tabbarLayout everywhere
@brandyscarney brandyscarney self-assigned this Apr 11, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.5 milestone Apr 11, 2016
brandyscarney added a commit that referenced this issue Apr 12, 2016
@brandyscarney
fix(tabs): remove tabbarIcons and fix windows styling to use tabbarLa…
81dd1cc 
…yout

update tabs docs.

BREAKING CHANGE: `tabbarIcons` is officially removed, please use
`tabbarLayout` instead. View the Tabs API docs for more information.

fixes #6126
references #5819
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.5
Development

No branches or pull requests
1 participant
@brandyscarney