Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ion-datetime> - several cosmetic issues #6764

Closed
keithdmoore opened this issue Jun 5, 2016 · 6 comments
Closed

<ion-datetime> - several cosmetic issues #6764

keithdmoore opened this issue Jun 5, 2016 · 6 comments
Assignees
Milestone

Comments

@keithdmoore
Copy link
Contributor

keithdmoore commented Jun 5, 2016

When using the Ionic2 datetime aka ion-datetime component with ion-item and ion-label, there are several cosmetic issues.

Issue 1. When using a stacked label, upon selecting a date, the date is placed in the center of the input field. I expect the date to be left justified under the label like other inputs do.

  <ion-item>
    <ion-label stacked>Date and Time1</ion-label>
    <ion-datetime displayFormat="MMM DD, YYYY HH:mm" [(ngModel)]="myDate"></ion-datetime>
  </ion-item>

Issue 2. When using a normal ion-label, it looks like the label is bolded and the font size is larger. I would expect the label styling to remain in tact when an ion-datetime component is placed under it. See sample code below issue 3.

Issue 3. Also, note the date starts to get truncated too early. Seems like it could be adjusted so that it starts to truncate when the date is closer to the label.

  <ion-item>
    <ion-label>Date and Time2</ion-label>
    <ion-datetime displayFormat="MMM DD, YYYY HH:mm" [(ngModel)]="myDate2"></ion-datetime>
  </ion-item>   

Here is a plunker that demonstrates the issues. Just select some dates for the date fields.

http://plnkr.co/edit/hxJ3TprMA5Aq2pwi0Fbv?p=preview

Cordova CLI: 6.1.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.7
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.5
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3.1 Build version 7D1014

@keithdmoore
Copy link
Contributor Author

@jgw96 Would you please remove the ios label and add the datetime label? Thanks!

@keithdmoore
Copy link
Contributor Author

keithdmoore commented Jun 5, 2016

@adamdbradley Any chance of this making it into the beta8 milestone? This is the only remaining issue I have seen with this component. Thanks for making Ionic2 great!

@danbucholtz
Copy link
Contributor

danbucholtz commented Jun 5, 2016

Hey @keithdmoore,

Thanks for submitting the issues 👍 . No promises on the beta 8 timeframe, but we'll tackle this asap!

Thanks,
Dan

@brandyscarney brandyscarney added this to the 2.0.0-beta.9 milestone Jun 6, 2016
@brandyscarney brandyscarney self-assigned this Jun 6, 2016
@brandyscarney
Copy link
Member

Thanks for the issue! This will be fixed in the beta 9 release, but if you'd like to check it out sooner I released a nightly version:

npm install --save ionic-angular@2.0.0-beta.8-201606091959

😄

@keithdmoore
Copy link
Contributor Author

Oh Brandy, I am so in love with you! You rock!

@basvdijk
Copy link

Thanks for reporting, had the same issue

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants