Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: rename tab config options to make more sense #7143

Closed
2 tasks done
brandyscarney opened this issue Jun 30, 2016 · 0 comments
Closed
2 tasks done

enhancement: rename tab config options to make more sense #7143

brandyscarney opened this issue Jun 30, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.11

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Jun 30, 2016 •
edited
Loading

The config options for tabs should be renamed to be more clear:

tabbarHighlight
tabbarLayout
tabSubPages
tabbarPlacement

should be:

tabsHighlight
tabsLayout
tabsHideOnSubPages
tabsPlacement

Make sure to print deprecation warnings for the old config options and update the API docs + theming docs for this.

  • API docs
  • Theming docs
@brandyscarney brandyscarney added this to the 2.0.0-beta.11 milestone Jun 30, 2016
@brandyscarney brandyscarney self-assigned this Jun 30, 2016
brandyscarney added a commit that referenced this issue Jul 7, 2016
@brandyscarney
refactor(tabs): rename tab input/config options to be more clear/cons…
41064bf 
…istent

BREAKING CHANGES:

Tab input/config options have been renamed. The following options were
renamed:

- `tabbarHighlight` -> `tabsHighlight`
- `tabbarLayout` -> `tabsLayout`
- `tabSubPages` -> `tabsHideOnSubPages`
- `tabbarPlacement` -> `tabsPlacement`

The previous names have been deprecated. They will still work in the
current release but will be removed in the future so please update to
the new names.

references #7143
This was referenced Jul 7, 2016
Closed
Closed
@Manduro Manduro mentioned this issue Jul 18, 2016
Closed
@jonnysmith1981 jonnysmith1981 mentioned this issue Oct 14, 2016
Closed
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.11
Development

No branches or pull requests
1 participant
@brandyscarney