Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File not found error surfaces local path instead of cloud path #118

Open
ejm714 opened this issue Feb 5, 2021 · 2 comments
Open

File not found error surfaces local path instead of cloud path #118

ejm714 opened this issue Feb 5, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ejm714
Copy link
Contributor

ejm714 commented Feb 5, 2021

I was loading a file from s3 and mistyped the file location. The error I got showed me the local tmp path, which was misleading. I think this should be the standard error you get when you try to do a cloud operation on a file that doesn't exist (something like "head object does not exist") or at least something that includes the cloud path instead of the local path.

DATA_DIR here is an S3Path.

Screen Shot 2021-02-05 at 3 33 22 PM

@ejm714 ejm714 added the bug Something isn't working label Feb 5, 2021
@pjbull pjbull added the good first issue Good for newcomers label Mar 13, 2021
@Mchristos
Copy link

I agree with this - it's really hard to debug the issue when I get this error. In my case, I'm passing a cloud path to another library, and the error happens inside it - so it's hard to know how to resolve the problem.

@pjbull
Copy link
Member

pjbull commented Nov 2, 2023

Thanks for the comment @Mchristos, unfortunately our library just can't know what other libraries try to do with our objects so there's not simple way to inject ourselves into these error messages. This is really another instance of #128, which has a complicated set of tradeoffs for the possible approaches.

Right now we're leaning towards the experimental work in #322 as the best approach, so I'd be curious if that works in your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants