Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client API: Create separate _copy_file method in addition to _move_file #143

Open
pjbull opened this issue May 20, 2021 · 0 comments
Open

Comments

@pjbull
Copy link
Member

pjbull commented May 20, 2021

Personally, I'd find it more intuitive to have separate methods _move_file and _copy_file, where the base implementation of _move_file would be something like:

def _move_file(self, src: BoundedCloudPath, dst: BoundedCloudPath) -> BoundedCloudPath:
    self._copy_file(src, dst)
    if src != dst:
        self._remove(src)
    return dst

Originally posted by @jayqi in #142 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant