Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for splits and bad video data #122

Open
2 tasks
pjbull opened this issue Oct 4, 2021 · 3 comments
Open
2 tasks

Add tests for splits and bad video data #122

pjbull opened this issue Oct 4, 2021 · 3 comments
Labels
good first issue Good for newcomers v2

Comments

@pjbull
Copy link
Member

pjbull commented Oct 4, 2021

#119 added a functionality to save out the splits if they weren't provided and to provided an all-zeros array with the correct shape if we can't load a video deep within the DataLoader. These items should have tests added for them:

  • add test for splits files getting written out
  • add test for bad video getting zeroes
@sunny1401
Copy link

@pjbull - Can I try working on this?

@ejm714
Copy link
Collaborator

ejm714 commented May 1, 2023

@sunny1401 sure!

For the first one on having a splits.csv written out, take a look at the existing tests for other functionality having to do with splits in test_config.py: https://github.com/drivendataorg/zamba/blob/master/tests/test_config.py. You'll want to add a test case where splits get automatically assigned and then check that that csv gets written (per this line)

@papapizzachess
Copy link

I am a college student working on a software engineering project for the next weeks until the end of this year. This is my first open source project on Github. I would appreciate any information that might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers v2
Projects
None yet
Development

No branches or pull requests

4 participants