Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create initial implementation #2

Closed
Tracked by #1
nathanclevenger opened this issue Oct 10, 2022 · 1 comment
Closed
Tracked by #1

Create initial implementation #2

nathanclevenger opened this issue Oct 10, 2022 · 1 comment
Assignees

Comments

@nathanclevenger
Copy link
Member

nathanclevenger commented Oct 10, 2022

I think typically JWT token-based services accept accountId, secret, & optionally scope & expiration TTL for the JWT

The advantage of this is that we don't have to wait for the lookup of an API key in ctx.do for the enrichment, as the metadata is in the token.

The downside is that it's much harder (although not impossible) to invalidate a token. We would need to create a list of invalidated token IDs ... and for performance we wouldn't want to wait for those to come through, although they could be in a env variable or fetched after validation (so potentially the initial request of a given worker could be allowed as to not have to await the result list).

@sam-lippert
Copy link
Contributor

Created in 70cf4b2, token invalidation tracked in #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants