Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] 스크린샷 테스트 #304

Closed
ParkJong-Hun opened this issue May 27, 2024 · 3 comments · Fixed by #323
Closed

[Proposal] 스크린샷 테스트 #304

ParkJong-Hun opened this issue May 27, 2024 · 3 comments · Fixed by #323
Assignees
@kez-lab
Labels
2024

Comments

@ParkJong-Hun
Copy link
Contributor

ParkJong-Hun commented May 27, 2024 •
edited
Loading

Kind (Required)

  • Proposal

Overview (Required)

  • Roborazzi나 Compose Preview Screenshot Testing으로 모든 컴포넌트, 화면의 Preview를 PR의 CI 단계에서 스크린샷으로 저장하고 Diff를 봇이 코멘트하게 하면 UI 대응과 의도치 않는 변경을 보다 수월하게 확인이 가능해요.
    • 브랜치에 스크린샷을 저장하도록 하면 브랜치 목록이 조금 리포지토리가 더러워지지만 가장 코스트가 좋아요.

Links
@ParkJong-Hun ParkJong-Hun changed the title [Proposal] [Proposal] 스크린샷 테스트 May 27, 2024
@kez-lab
Copy link
Contributor

kez-lab commented Jun 3, 2024

🙋‍♂️

@taehwandev
Copy link
Member

@KwakEuiJin 진행부탁드려요.

@kez-lab
Copy link
Contributor

kez-lab commented Jun 4, 2024

@taehwandev 넵 감사합니다☺️

@kez-lab kez-lab mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kez-lab kez-lab

Labels
2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature/roborazzi]: Screenshot Test 작업 추가 kez-lab/DroidKnightsApp
3 participants
@taehwandev @ParkJong-Hun @kez-lab