Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why return nil after unmarshal failed #160

Closed
Markle-ddp opened this issue Nov 3, 2022 · 2 comments
Closed

why return nil after unmarshal failed #160

Markle-ddp opened this issue Nov 3, 2022 · 2 comments

Comments

@Markle-ddp
Copy link
Contributor

https://github.com/golang-module/carbon/blob/4c16beed0e063bc69cb446bd9fb2e1be949e3aa3/json.go#L94

why return nil ?

Maybe The return value should be c.Error?
@Markle-ddp Markle-ddp changed the title why return nil ? why return nil after unmarshal fail Nov 3, 2022
@Markle-ddp Markle-ddp changed the title why return nil after unmarshal fail why return nil after unmarshal failed Nov 3, 2022
@gouguoyin
Copy link
Collaborator

Fix in #161

@Issues-translate-bot
Copy link
Collaborator

The issue body's language is not English, translate it automatically, please use English next time. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Fix in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gouguoyin @Markle-ddp @Issues-translate-bot