Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.2 in Windows ls not returning results unless verbose #68

Closed
ryallappasetty opened this issue Mar 21, 2017 · 5 comments
Closed

v2.0.2 in Windows ls not returning results unless verbose #68

ryallappasetty opened this issue Mar 21, 2017 · 5 comments

Comments

@ryallappasetty
Copy link

When I run dbxcli with the ls / it does not return anything. if I run it verbosely e.g. dbxcli ls / -v it returns:

2017/03/20 20:03:15 client.go:1510: arg: &{ false false false false}
2017/03/20 20:03:15 client.go:1527: req: &{POST https://api.dropboxapi.com/2/files/list_folder HTTP/1.1 1 1 map[Content-Type:[application/json]] {0xc042067950} 0x653400 124 [] false api.dropboxapi.com map[] map[] map[] }
2017/03/20 20:03:16 client.go:1531: resp: &{200 OK 200 HTTP/1.1 1 1 map[X-Dropbox-Http-Protocol:[None] X-Frame-Options:[SAMEORIGIN] Content-Type:[application/json] Pragma:[no-cache] X-Server-Response-Time:[186] Server:[nginx] Vary:[Accept-Encoding] X-Content-Type-Options:[nosniff] X-Dropbox-Request-Id:

plus directory information and file names.

Running on fully patched Windows 10.

@diwakergupta
Copy link
Collaborator

@ryallappasetty Weird. I don't have a Windows machine handy for testing, so it'll be a bit hard for me to debug this immediately. Are you comfortable building/testing dbxcli? Maybe you can help me figure this out!

@diwakergupta
Copy link
Collaborator

@ryallappasetty I'm finally able to test on Windows and am able to repro this bug, thanks again for the report! I'm investigating, will update once I have more info.

@diwakergupta
Copy link
Collaborator

Alright, dbxcli ls -l works just fine so it's just a display issue. I believe the bug is in golumns.Display -- @grantseltzer can you take a look?

@diwakergupta
Copy link
Collaborator

Specifically, I think GetSize (https://github.com/golang/crypto/blob/master/ssh/terminal/util.go#L81) doesn't work as-is on Windows.

On that note, I'm also considering if it's worth pulling in the crypto/ssh dependency just for terminal size. Will explore options.

@diwakergupta
Copy link
Collaborator

@ryallappasetty should be fixed with v2.0.4 onwards -- can you download the latest release and try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants