Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch Deprecation of response.buffer #1144

Closed
toddjudd opened this issue Sep 21, 2024 · 1 comment
Closed

node-fetch Deprecation of response.buffer #1144

toddjudd opened this issue Sep 21, 2024 · 1 comment

Comments

@toddjudd
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch dropbox@10.34.0 for the project I'm working on.

I ran into an issue where using the built in fetch with node v20 didn't work so uppon switching to node-fetch I ran into a deprication warning

(node:40056) [node-fetch#buffer] DeprecationWarning: Please use 'response.arrayBuffer()' instead of 'response.buffer()'
(Use `node --trace-deprecation ...` to show where the warning was created)

Here is the diff that solved my problem:

diff --git a/node_modules/dropbox/cjs/src/response.js b/node_modules/dropbox/cjs/src/response.js
index ec37d1b..fe42b32 100644
--- a/node_modules/dropbox/cjs/src/response.js
+++ b/node_modules/dropbox/cjs/src/response.js
@@ -64,7 +64,7 @@ function parseDownloadResponse(res) {
         return resolve(data);
       });
     } else {
-      res.buffer().then(function (data) {
+      res.arrayBuffer().then(function (data) {
         return resolve(data);
       });
     }

This issue body was partially generated by patch-package.

@toddjudd
Copy link
Author

Closed as it duplicates #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant