Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api to allow upload progress monitoring #157

Open
acornejo opened this issue Sep 24, 2017 · 4 comments
Open

add api to allow upload progress monitoring #157

acornejo opened this issue Sep 24, 2017 · 4 comments

Comments

@acornejo
Copy link

This is fairly straightforward to do with superagent (which is used by this sdk).

request
   .post('/files/upload')
   .send(file)
   .on('progress', function(e) {
      console.log(e.percent);
   }

Thus just need to change the API to allow the user to specify a progress callback.

@greg-db
Copy link
Contributor

greg-db commented Sep 25, 2017

Thanks! I'll send this request along to the team.

@nikshepsvn
Copy link

Are open source contributions for these type of issues allowed @greg-db ?

@greg-db
Copy link
Contributor

greg-db commented Oct 10, 2017

@nikshepsvn Sure, we welcome pull requests.

@pran1990
Copy link
Contributor

@nikshepsvn thanks for offering, if you were. One thing I'd like to warn you about is that we are moving to fetch soon, so a change dependent on superagent might be really short-term for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants