Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Add upper case and title case support #2

Closed
kkaefer opened this issue Jun 11, 2014 · 3 comments
Closed

Add upper case and title case support #2

kkaefer opened this issue Jun 11, 2014 · 3 comments

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Jun 11, 2014

Seems like the data already contains upper case and title case mappings?

@kkaefer
Copy link
Contributor Author

kkaefer commented Jun 11, 2014

Why is

# "upper_offset": make_translation_map("uppercase_offset", lambda info: info.uppercase - info.codepoint if info.uppercase else 0),
commented out?

@j4cbo
Copy link
Contributor

j4cbo commented Oct 7, 2015

Perhaps too late to be useful, but just for completeness...

We only implemented lowercase because that's all we had need for internally, and wanted to save on binary size as much as possible. Adding upper/titlecase as a config option (#define maybe?) would be an option, but leaving them out was intentional.

@j4cbo j4cbo closed this as completed Oct 7, 2015
@kkaefer
Copy link
Contributor Author

kkaefer commented Oct 8, 2015

For reference, we switched to https://bitbucket.org/alekseyt/nunicode

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants