Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad URL: /incidents/{ID}/log_entries/count #80

Open
jjinno opened this issue May 20, 2019 · 1 comment
Open

Bad URL: /incidents/{ID}/log_entries/count #80

jjinno opened this issue May 20, 2019 · 1 comment

Comments

@jjinno
Copy link

jjinno commented May 20, 2019

For tracking purposes.

The v2 REST API no longer officially supports the /count path. Although empirical evidence would suggest it still exists for /incidents/count, there is no documentation supporting this, and plenty of support conversations suggesting otherwise. This is especially true for sub-container elements such as Incident.log_entries

To be v2 compliant, all count() calls should be changed to use the documented total=true parameter on a single paginated request. The use of limit=1 should theoretically allow for the smallest possible request, though some testing on older incidents seems to suggest that this must be limit=2 or higher to avoid HTTP errors.

@jjinno
Copy link
Author

jjinno commented May 21, 2019

PR #83 (fyi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant