-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary loop #75
Comments
I believe this code was auto-generated, right @danielrh ? |
Hello, I just run into this. Will it be improved since this 10% speedup looks easy to get? |
@danielrh Is it a bug or an unnecessary loop? The last statement in this loop is a break, indicating it is executed once whatsoever. I don't see why 'continue30: loop{...} is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rust-brotli/src/enc/backward_references/hq.rs
Line 920 in 5d82b69
This loop
continue30
is unnecessary because it will eventually break at line 1018. If we remove this loop and change all thebreak 'continue30;
intocontinue
and change all thebreak 'break29;
intobreak
, the execution time will decreased from 3.76s to 3.43s based on my test, which is a 1.1x speedup.Hope this information helps!
The text was updated successfully, but these errors were encountered: