New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: use missing vertices after merging #446

Closed

hoangquocvietuet opened this issue Feb 7, 2025 · 0 comments

Contributor

hoangquocvietuet commented Feb 7, 2025

Currently, we don't use missing arrays that contain vertices invalidated by merging operations.

https://github.com/topology-foundation/ts-drp/blob/c5d2394026b256428ac50632636598ef786be29e/packages/node/src/handlers.ts#L155

So, we always perform sync operations to synchronize all missing ones between peers after update and merge operations.

However, we can improve efficiency by reusing missing information from the update operation:

Vertices that the other peer has but we do not.

This approach reduces one message in the communication between peers.

ghost added this to DRP

github-project-automation bot moved this to 🔮 Backlog in DRP

hoangquocvietuet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment