Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing an array to no-data doesn't work #47

Open
j3j5 opened this issue Mar 26, 2024 · 0 comments
Open

Passing an array to no-data doesn't work #47

j3j5 opened this issue Mar 26, 2024 · 0 comments

Comments

@j3j5
Copy link

j3j5 commented Mar 26, 2024

Hi, I'm using this package but I just noticed that passing an array to no-data option in the settings (as stated on the readme) doesn't prevent the tables on the array from dumping their data.

I've tracked the issue and it seems to come from this line, which checks whether no-data is enabled, which, in this case returns false because isEnabled() does a strict check with true, and $this->settings[no-data] is an array.

I can create a PR if you want, but I'm not sure why the check is there on the first place (there's a comment saying // don't break compatibility with old trigger) , so I'm not sure what the best solution would be, suggestions welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant