Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drush make fails if included file is empty #1908

Closed
pendashteh opened this issue Jan 10, 2016 · 2 comments
Closed

Drush make fails if included file is empty #1908

pendashteh opened this issue Jan 10, 2016 · 2 comments

Comments

@pendashteh
Copy link

This is a working .make file:

; build.make
core = "7.x"
api = "2"
projects[drupal][version] = "7.x"
includes[] = "_modules.make"
includes[] = "_themes.make"
includes[] = "_libraries.make"

However, if there is nothing in _libraries.make:

; _libraries.make
; +++++ Libraries +++++

Then it will throw error upon running drush make:

$ drush make build.make _build
Illegal string offset 'format' make.utilities.inc:676 [warning]
array_replace_recursive(): Argument #1 is not an array make.utilities.inc:98 [warning]
array_reverse() expects parameter 1 to be array, null given make.utilities.inc:103 [warning]
array_replace_recursive(): Argument #2 is not an array make.utilities.inc:98 [warning]
array_reverse() expects parameter 1 to be array, null given make.utilities.inc:103 [warning]
The 'core' attribute is required [error]
You need to specify an API version of two in your makefile: [warning]
api = 2
Beginning to build build.make. [ok]
No core project specified. [error]
Drush Make failed to download all projects. See the log above for the specific errors. [error]

&&

Drush Version : 8.1-dev

@xtfer
Copy link

xtfer commented Oct 11, 2017

The problem appears to be that, if the core= attribute is not specified, Drush attempts to detect the type by checking for valid YAML. Just about any .ini file will return as valid YAML, so it fails. The workaround is to add a core= property to the make file.

@pendashteh
Copy link
Author

Confirmed that adding core attribute to the included file does fix the issue. Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants