-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported boolean yaml strings are not quoted consistently #2673
Labels
Comments
I am under the vague impression that this can happen when some team members have pecl yaml extension and some don't. |
Thanks for the tip. I tried to verify on my own machine if this is indeed the problem. It seems that pecl yaml is not the cause; at least it is not with the combination of software versions I tested. Initial situation:
What I tried
Results so far
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Excuse me if this is not the right place to ask, I'm not sure if this is a Drush problem.)
When my colleague exports config with
drush cex
, some strings are quoted. I think I was able to trace this back to\Symfony\Component\Yaml\Escaper::requiresSingleQuoting()
, and the behavior seems to make sense because those strings ('null', '~', 'true', 'false', 'y', 'n', 'yes', 'no', 'on', 'off'
) could otherwise be interpreted as booleans.Unfortunately the behavior is not consistent across our team. Sometimes the strings are quoted, sometimes they aren't, so we keep polluting the git history with changed config. We have verified that we use the same Drush version (8.1.10) and Composer version (1.3.2). Since we commit our composer.lock file to git, we also use the same packages. We are not on the exact same PHP7 versions, but looking at the code I think that the PHP version should not matter in this case.
What could be the cause of this? What can I do, or what other information could be relevant to figure out why this is happening? Thank you.
The text was updated successfully, but these errors were encountered: